Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a User-Agent when using the Lambda Runtime API #98

Merged
merged 2 commits into from
May 30, 2020
Merged

Add a User-Agent when using the Lambda Runtime API #98

merged 2 commits into from
May 30, 2020

Conversation

bmoffatt
Copy link
Contributor

Addresses #96 - This will help you stand out in a crowd of "Unknown/Unknown" in our logs

@swift-server-bot
Copy link

Can one of the admins verify this patch?

3 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

weissi
weissi reviewed May 30, 2020
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks like a good idea to me. Left a small note :)

@tomerd
Copy link
Contributor

tomerd commented May 30, 2020

@swift-server-bot add to whitelist

@tomerd
Copy link
Contributor

tomerd commented May 30, 2020

@swift-server-bot test this pease

@fabianfett fabianfett linked an issue May 30, 2020 that may be closed by this pull request
add user-agent to more identify the runtime #96
Closed
@tomerd tomerd merged commit eaa6fb6 into swift-server:master May 30, 2020
@tomerd tomerd added this to the 0.1.1 milestone Jun 1, 2020
@tomerd tomerd added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Jun 1, 2020
@garnaat
Copy link

garnaat commented Jun 2, 2020

I assume you are maintaining some sort of version string for this package somewhere in the code. If so, it might be a good idea to incorporate the version string into the User Agent string. It would make it possible to track usage of the runtime across versions.

@tomerd tomerd mentioned this pull request Jun 2, 2020
Open
@tomerd
Copy link
Contributor

tomerd commented Jun 2, 2020

good idea @garnaat #108

@weissi
Copy link
Contributor

weissi commented Jun 2, 2020 •
edited
Loading

@tomerd / @garnaat I filed https://bugs.swift.org/browse/SR-12926

@weissi weissi mentioned this pull request May 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi left review comments

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

add user-agent to more identify the runtime
6 participants
@bmoffatt @swift-server-bot @tomerd @garnaat @weissi @fabianfett