Implement self-update command
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to unify download, add tests
todo: - update existing usages of mock HTTP downloader - finish self update tests
adam-fowler
approved these changes
Nov 28, 2023
Sources/SwiftlyCore/HTTPClient.swift
Outdated
| } | ||
| } | ||
|
|
||
| private func makeRequest(url: String) -> HTTPClientRequest { | ||
| var request = HTTPClientRequest(url: url) | ||
| request.headers.add(name: "User-Agent", value: "swiftly") |
There was a problem hiding this comment.
You should include the swiftly version here as well
Sources/SwiftlyCore/HTTPClient.swift
Outdated
| private struct Response { | ||
| let status: HTTPResponseStatus | ||
| let buffer: ByteBuffer | ||
| } | ||
|
|
||
| private let downloader: ToolchainDownloader | ||
| private let inner: HTTPRequestExecutor |
Sources/SwiftlyCore/HTTPClient.swift
Outdated
| // As a heuristic for if we've hit the 404 page, we check to see if the content is HTML. | ||
| if url.host == "download.swift.org" { | ||
| guard !response.headers["Content-Type"].contains(where: { $0.contains("text/html") }) else { | ||
| throw SwiftlyHTTPClient.DownloadNotFoundError(url: url.path) |
There was a problem hiding this comment.
I was going to ask can't you check the response status, but apparently not. The 404 page returns a status of 302. You could check the location header is https://swift.org/404.html instead though
There was a problem hiding this comment.
So after following the redirect, swift.org/404.html does in fact return a status code of 404 nowadays, so I've just gone ahead and removed this special check altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a
self-updatecommand, which can be used to update swiftly in-place.This also expands the toolchain downloading mocking framework introduced in #67 to be able to be used for any arbitrary HTTP request. This allows us to use mocking to simulate there being a swiftly update to make, even though there are none currently.
For the 0.2.0 release, users will need to install via
swiftly-install.sh, but every release afterwards they can do it via a simpleswiftly self-update.