Verify signatures of toolchains before installing #94
Conversation
todo:
- verify keys are installed, skip otherwise? or install? maybe
confirm then install
- add message suggesting users should report validation error?
- maybe not in case swiftly users spam swift in error
- add option to skip validation
- add tests
- integration happy path
- mocked failed validation
- succeed when skip validation
- installing keys
- gpg not installed
- install test for installing gpg + keys
- option to skip installing gpg + keys in install script?
|
@swift-server-bot test install please |
1 similar comment
|
@swift-server-bot test install please |
|
@swift-server-bot test please |
|
@swift-server-bot test install please |
|
@swift-server-bot test install please |
|
If you don't have any of the requirements to check the toolchain signature, you get an error message after downloading the tar ball. You do as suggested and then have to download the tar ball again. Perhaps we should verify for the existence of Otherwise we are good |
|
Also RHEL and AL2 are failing |
|
@swift-server-bot test install please |
|
The failure on 18.04 is due to swift.org not publishing the latest snapshots for that platform. I filed apple/swift-org-website#647 to look into it. If swift.org has indeed stopped publishing releases for 18.04, we may have to consider dropping support for it, at least for snapshot installations. |
|
Yeah Swift have stopped supporting 18.04 |
Closes #11