Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calendar picker option to textfields #224

Closed
bartreardon opened this issue Feb 2, 2023 · 7 comments
Closed

Add calendar picker option to textfields #224

bartreardon opened this issue Feb 2, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@bartreardon
Copy link
Collaborator

Title 馃憜

@bartreardon bartreardon self-assigned this Feb 2, 2023
@bartreardon bartreardon added the enhancement New feature or request label Feb 2, 2023
@BigMacAdmin
Copy link
Collaborator

Being able to set a "no later than this" date would be great, but added complexity would be "Deadline" (hard and fast date) vs. "Future" (no more than 7 days out).

@kspitzer14
Copy link

7 days for "No Later Than" is good, but my users can be a bit... persnickety. 14 might be better.

@bartreardon
Copy link
Collaborator Author

the macOS implementation of the date picker in SwiftUI is notoriously fickle. I'm not setting my sights any higher than "allow the user to pick a date" but we'll see how we go.

bartreardon added a commit that referenced this issue Jan 2, 2024
`--textfield "date testing",isdate=true`

No validation at this point in time. Just puts the selected date into the textfield.
@bartreardon
Copy link
Collaborator Author

initial implementation.

no validation or any other fancyness like date range - just takes the date value and puts it as text into the textfield.

image

@BigMacAdmin
Copy link
Collaborator

Date stuff is notoriously difficult based on region, timezone, etc.

Your screenshot shows this, since you're using Au formatting your January 2 shows as 2/1 while mine would show 1/2.

My 2 cents: This will be infinitely easier to program around if the return is a unix epoch time stamp. Wondering if you can also get the clock on their for a specific time selection. Giving back unix epoch time would make handling everything else programmatically a lot easier.

image

@bartreardon
Copy link
Collaborator Author

As mentioned in slack, unix epoch is where I'll be ultimately going with this. Just wanted to get the UX behaviour sorted first to make sure it's going to work before making too many under the hood changes to support it.

The idea is when using a date, what gets displayed is a localised representation. What gets stored is the full date as a unix timestamp and that's what will get sent to output for processing. The data to do that is already stored, there's jsut no logic to expose that in the results yet 馃檪

@bartreardon
Copy link
Collaborator Author

I'm closing this as done. Any future enhancements or changes can be handled in a specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants