Support for showing dialog windows at the loginwindow #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
|
I swear I made those changes (or similar) at some time in the past and it wasn't working for me - do you have a test to validate how it works? |
|
@bartreardon are you still needing a test case? I see your request above but also that this was merged into dev_2.5.0. Does that mean you tested it successfully? It had it working back in January in #68 (comment) but that test system has been wiped many times since. I can work on a new test tonight (US Mountain Time) or this weekend. |
|
all good - I worked it out 🙂 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for showing dialog windows at the loginwindow with
--loginwindow. Dialog still needs to be launched by a LoginWindow launch agent as described here