Introduce delimiter guessing #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DivineDominion
requested review from
ondrej-kvasnovsky,
lukestringer90 and
orangeince
|
@orangeince Thanks for taking a look! Could you select "approve" from the review options if you'd be fine with me merging this? |
orangeince
approved these changes
Jan 8, 2022
|
@DivineDominion Sorry, it my mistake. |
|
Thanks for merging! Didn't notice the notification when you approved, sorry 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the app where I use SwiftCSV, users often try to import CSV with either tabs or semicolons as delimiters.
I figured delimiter guessing is useful for everyone, not just users of my app, so here's an attempt to add that functionality.
What do you think about these changes?
If we merge this, I'd bump the version to v0.7.0 because this is breaking backwards compatibility.