Skip to content

Commit

Permalink
[clang] Disable assertion that can "easily happen"
Browse files Browse the repository at this point in the history
Disable the assertion for getting a module ID for non-local,
non-imported module. According to the FIXME this can "easily happen" and
indeed, we're hitting this assertion regularly. Disable it until it can
be properly investigated.

rdar://99352728

Differential revision: https://reviews.llvm.org/D136290
  • Loading branch information
JDevlieghere committed Oct 19, 2022
1 parent af2b221 commit 97b9130
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions clang/lib/Serialization/ASTWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2669,12 +2669,12 @@ unsigned ASTWriter::getLocalOrImportedSubmoduleID(const Module *Mod) {
}

unsigned ASTWriter::getSubmoduleID(Module *Mod) {
unsigned ID = getLocalOrImportedSubmoduleID(Mod);
// FIXME: This can easily happen, if we have a reference to a submodule that
// did not result in us loading a module file for that submodule. For
// instance, a cross-top-level-module 'conflict' declaration will hit this.
unsigned ID = getLocalOrImportedSubmoduleID(Mod);
assert((ID || !Mod) &&
"asked for module ID for non-local, non-imported module");
// assert((ID || !Mod) &&
// "asked for module ID for non-local, non-imported module");
return ID;
}

Expand Down

0 comments on commit 97b9130

Please sign in to comment.