[Coroutine][DebugInfo] Remove the memory attributes on coro-async-dec… #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laration.ll (NFC) (llvm#66088) According to @drodriguez's reminder in swiftlang#7168 (comment), `memory` breaks the backport to the apple branch. And this is irrelevant to that test. Delete to get better a test case. (cherry picked from commit 19b664d)
|
@swift-ci test |
|
@DianQK Does this need to be cherry-picked to swift/release/5.9 and/or swift/release/5.10 and/or stable/20230725? |
|
@swift-ci test |
|
@swift-ci test windows |
drodriguez
referenced
this pull request
Dec 15, 2023
Type dereferenced fragments are specified by offset and length in bits. The representation in CodeView is defined in terms of byte offsets. If the bit slice overlaps at a byte that is included, we would create invalid definition ranges. Consider the following scenario: ~~~ 01234567 01234567 ---------+--------- ==== ====== ~~~ Here bits 1-4 are marked as defined as well as bits 7-9. The byte range for the second portion overlaps and so we would say that bytes 1 and 2 are valid though there is potentially a hole. There is no way to represent this in the defined range for the local variable in CodeView. We simply can drop the fragment definition in such a scenario with the variables are "optimized out". Thanks to @rnk and @hjyamauchi for the discussion around this.
|
Looks like we've moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
memoryas discussed in #7168.(cherry picked from commit 19b664d)
@adrian-prantl @felipepiovezan @drodriguez