Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle diagnostics in secondary files correctly #1528

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

ahoppen
Copy link
Contributor

@ahoppen ahoppen commented Jun 27, 2024

Fixes #1516
rdar://130503535

@ahoppen
Copy link
Contributor Author

ahoppen commented Jun 27, 2024

@swift-ci Please test

@ahoppen
Copy link
Contributor Author

ahoppen commented Jun 27, 2024

@swift-ci Please test

@ahoppen ahoppen force-pushed the diagnostics-in-secondary-files branch from 236ff1b to 617cdcc Compare June 27, 2024 15:38
@ahoppen
Copy link
Contributor Author

ahoppen commented Jun 27, 2024

@swift-ci Please test

@ahoppen
Copy link
Contributor Author

ahoppen commented Jun 27, 2024

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Contributor Author

ahoppen commented Jun 27, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit a4b6a74 into swiftlang:main Jun 28, 2024
3 checks passed
@ahoppen ahoppen deleted the diagnostics-in-secondary-files branch June 28, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceKit-LSP is reporting wrong file for diagnostic related information
2 participants