-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unresolved H4 links #36
Comments
cc @franklinsch |
It's probably worth at least asking whether DocC might want to support > H3 heading anchors, especially given our focus here on longer-form content where it's more likely that content will have headings with more depth. |
I'm +1 for support "> H3 heading anchors" (Whether by default or via a flag) What's your opinion on this? Or we could make some discussion on tomorrow's meeting @franklinsch |
Ping @franklinsch |
Sorry I missed this. Supporting links to >h3 makes sense to me! |
After #403 is merged, there will only 1 warning left for swift-book 👇
Which is tracked by #1 |
Thanks @Kyle-Ye! Confirmed that the H4 link in the revision history works now. |
In some places, TSPL links to a H4 as an anchor point — for example:
However, swift-docc currently only supports H1, H2 and H3 as an anchor to reference.
https://github.com/apple/swift-docc/blob/5fe2d1331eba2243163366e4d25259b86a44e5db/Sources/SwiftDocC/Model/DocumentationNode.swift#L113-L124
Should we update the structure of content in this repo or should this be a feature/bug on swift-docc to be fixed?
If we are going to fix it on swift-docc, should we add a flag to let the consumer decide which heading level we should add as anchor or just extend it to level 4?
The text was updated successfully, but these errors were encountered: