Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftSyntax] Remove force unwrapping for source location #513

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 14, 2023

@kimdv kimdv changed the title Remove force unwrapping for source location [SwiftSyntax] Remove force unwrapping for source location Apr 14, 2023
@kimdv kimdv force-pushed the kimdv/remove-ComputedLocation branch from 9d83f38 to 9e1b56c Compare April 14, 2023 12:33
Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sources/SwiftFormatCore/Finding+Convenience.swift Outdated Show resolved Hide resolved
@kimdv kimdv force-pushed the kimdv/remove-ComputedLocation branch from 9e1b56c to cd9695b Compare April 14, 2023 14:28
@kimdv
Copy link
Contributor Author

kimdv commented Apr 18, 2023

@kimdv
Copy link
Contributor Author

kimdv commented Apr 19, 2023

@kimdv
Copy link
Contributor Author

kimdv commented Apr 20, 2023

@ahoppen @allevato can you merge?

@allevato allevato merged commit cf22332 into swiftlang:main Apr 20, 2023
@allevato
Copy link
Member

Done, thanks!

@kimdv
Copy link
Contributor Author

kimdv commented Apr 20, 2023

@allevato Can you also merge the stress tester PR?

@kimdv kimdv deleted the kimdv/remove-ComputedLocation branch April 20, 2023 16:06
@allevato
Copy link
Member

Unfortunately I don't have write access to that repo, so @ahoppen or someone else will need to merge it.

@kimdv
Copy link
Contributor Author

kimdv commented Apr 20, 2023

Okay, but thanks a lot @allevato ✌️

kimdv pushed a commit to kimdv/swift-format that referenced this pull request Apr 20, 2023
…tion

[SwiftSyntax] Remove force unwrapping for source location
kimdv pushed a commit to kimdv/swift-format that referenced this pull request May 18, 2023
…tion

[SwiftSyntax] Remove force unwrapping for source location
kimdv pushed a commit to kimdv/swift-format that referenced this pull request May 22, 2023
…tion

[SwiftSyntax] Remove force unwrapping for source location
kimdv pushed a commit to kimdv/swift-format that referenced this pull request May 22, 2023
…tion

[SwiftSyntax] Remove force unwrapping for source location
allevato added a commit to allevato/swift-format that referenced this pull request Jun 29, 2023
…tion

[SwiftSyntax] Remove force unwrapping for source location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants