Fix try/await expressions in NoAssignmentInExpressions.
#533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule only checked whether the _immediate_ parent of an expression like `x = y` was a `CodeBlockItem`. In cases like `try x = y`, the `try` wraps the entire expression and the `CodeBlockItem` would be the parent of that. So we look through any `TryExpr`s or `AwaitExpr`s we see when searching for the `CodeBlockItem`.
|
cc @dylansturg |
dylansturg
approved these changes
May 25, 2023
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Jun 29, 2023
Fix `try`/`await` expressions in `NoAssignmentInExpressions`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule only checked whether the immediate parent of an expression like
x = ywas aCodeBlockItem. In cases liketry x = y, thetrywraps the entire expression and theCodeBlockItemwould be the parent of that. So we look through anyTryExprs orAwaitExprs we see when searching for theCodeBlockItem.