Further improve multiline string formatting. #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes remove unnecessary grouping around multiline string
literals that were forcing subexpressions to wrap in less than
ideal ways. Since multiline strings force hard line breaks after
the open quotes, we can remove the grouping and produce better
results when complex expressions are involved. For example,
```swift
let x = """
abc
def
""" + """
ghi
jkl
"""
```
Before this change, we were forcing breaks after the `=` and
before the `+`. Now, we only do so if the open quotes would
overflow the line.
|
cc @dylansturg |
dylansturg
approved these changes
May 26, 2023
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Jun 29, 2023
…fixes Further improve multiline string formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes remove unnecessary grouping around multiline string literals that were forcing subexpressions to wrap in less than ideal ways. Since multiline strings force hard line breaks after the open quotes, we can remove the grouping and produce better results when complex expressions are involved. For example,
Before this change, we were forcing breaks after the
=and before the+. Now, we only do so if the open quotes would overflow the line.