Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async throws function types when they appear in an expression context. #539

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

allevato
Copy link
Member

@allevato allevato commented Jun 5, 2023

Also unify the way we handle async throws now that they are all contained inside effect specifier nodes that share a common EffectSpecifiersSyntax protocol conformance.

Fixes #538.

…ontext.

Also unify the way we handle `async throws` now that they are all contained
inside effect specifier nodes that share a common `EffectSpecifiersSyntax`
protocol conformance.

Fixes swiftlang#538.
@allevato
Copy link
Member Author

allevato commented Jun 5, 2023

cc @dylansturg

Copy link
Contributor

@dylansturg dylansturg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this one when you sent it out!

@allevato allevato merged commit 5510297 into swiftlang:main Jun 8, 2023
@allevato allevato deleted the async-throws branch June 8, 2023 20:44
allevato added a commit to allevato/swift-format that referenced this pull request Jun 29, 2023
Fix `async throws` function types when they appear in an expression context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"async throws" gets smooshed together in some cases
2 participants