Fix deprecated SwiftSyntax api warnings #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
reviewed
Jul 3, 2023
| @@ -321,28 +321,28 @@ class LintPipeline: SyntaxVisitor { | |||
|
|
|||
| extension FormatPipeline { | |||
|
|
|||
| func visit(_ node: Syntax) -> Syntax { | |||
| func rewrite(_ node: Syntax) -> Syntax { | |||
There was a problem hiding this comment.
This file is generated by https://github.com/apple/swift-format/blob/main/Sources/generate-pipeline/PipelineGenerator.swift. Can you update that code and then rerun it to verify that the generated output here is correct?
There was a problem hiding this comment.
I totally overlooked that... Addressed and combined previous commits into one.
kitasuke
force-pushed
the
fix-swift-syntax-deprecated-warnings
branch
from
df70108
to
b4088ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main branch of SwiftSyntax renamed some properties and functions, so this PR applied them in swift-format and fix the pipeline generator.