Replace the ReplaceTrivia rewriter with direct trivia mutations.
#588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were using a `SyntaxRewriter` to replace trivia on nodes. Historically, this originated from a time (I believe) when trivia wasn't directly mutable on nodes. The vast majority of these uses were replacing the extents: the leading trivia of the first token of a node or the trailing trivia of the last token. This can be done more easily now by just mutating those properties of the nodes. Even in cases where we were doing something slightly more advanced, it's clearer to do in-place mutation and reconstruction; having this specialized rewriter no longer held its weight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using a
SyntaxRewriterto replace trivia on nodes. Historically, this originated from a time (I believe) when trivia wasn't directly mutable on nodes. The vast majority of these uses were replacing the extents: the leading trivia of the first token of a node or the trailing trivia of the last token. This can be done more easily now by just mutating those properties of the nodes.Even in cases where we were doing something slightly more advanced, it's clearer to do in-place mutation and reconstruction; having this specialized rewriter no longer held its weight.