Fix a bunch of FIXMEs around linter findings. #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Whitespace linter: Fix improper pluralization of "add 1 line breaks". - `DoNotUseSemicolons`: Only show the part of the message about moving the next statement to a new line if a statement actually follows the semicolon on the same line. - `DontRepeatTypeInStaticProperties`: Place the finding on the identifier, not at the start of the decl. - `FullyIndirectEnum`: Move the finding to the `enum` keyword and add notes to each `indirect` keyword that should be removed. - `GroupNumericLiterals`: Clean up the finding message and include the numeric base of the literal. - `NoAccessLevelOnExtensionDeclaration`: Add notes for each extension declaration that needs to have the access modifier added to it. - `NoCasesWithOnlyFallthrough`: Put findings at the right locations. - `NoEmptyTrailingClosureParentheses`: Place the finding on the parentheses themselves. - `NoParensAroundConditions`: Place the finding on the parentheses themselves. - `TypeNamesShouldBeCapitalized`: Place the finding on the name instead of the declaration and clean up the message to make it more consistent with other rules. - `UseEarlyExits`: Put findings at the right locations. - `UseTripleSlashForDocumentationComments`: Place the finding on the comment, not on the declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoNotUseSemicolons: Only show the part of the message about moving the next statement to a new line if a statement actually follows the semicolon on the same line.DontRepeatTypeInStaticProperties: Place the finding on the identifier, not at the start of the decl.FullyIndirectEnum: Move the finding to theenumkeyword and add notes to eachindirectkeyword that should be removed.GroupNumericLiterals: Clean up the finding message and include the numeric base of the literal.NoAccessLevelOnExtensionDeclaration: Add notes for each extension declaration that needs to have the access modifier added to it.NoCasesWithOnlyFallthrough: Put findings at the right locations.NoEmptyTrailingClosureParentheses: Place the finding on the parentheses themselves.NoParensAroundConditions: Place the finding on the parentheses themselves.TypeNamesShouldBeCapitalized: Place the finding on the name instead of the declaration and clean up the message to make it more consistent with other rules.UseEarlyExits: Put findings at the right locations.UseTripleSlashForDocumentationComments: Place the finding on the comment, not on the declaration.