Don't do anything if the input is empty. #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting/linting a 0 byte file should not insert or diagnose a trailing newline. This makes us consistent with clang-format's behavior even when its `InsertNewlineAtEOF` setting is enabled. --- Behavior before: ``` $ echo -n 'foo()' | .build/debug/swift-format | hexdump -C 00000000 66 6f 6f 28 29 0a |foo().| 00000006 $ echo -n '' | .build/debug/swift-format | hexdump -C 00000000 0a |.| 00000001 ``` Behavior after: ``` $ echo -n 'foo()' | .build/debug/swift-format | hexdump -C 00000000 66 6f 6f 28 29 0a |foo().| 00000006 $ echo -n '' | .build/debug/swift-format | hexdump -C <no output> ``` Likewise, lint mode now emits no finding for an empty file instead of previously emitting `warning: [AddLines] add 1 line breaks`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting/linting a 0 byte file should not insert or diagnose a trailing newline. This makes us consistent with clang-format's behavior even when its
InsertNewlineAtEOFsetting is enabled.Behavior before:
Behavior after:
Likewise, lint mode now emits no finding for an empty file instead of previously emitting
warning: [AddLines] add 1 line breaks.