Replace with calls with in-place mutation; clean up helpers.
#609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some extensions no longer in use, and rewrite the `DeclModifierListSyntax` helpers to take keywords instead of strings.
These were only used in one place and have implementations that are pretty specific to just the calling rule, so move them side-by-side with that rule and make them file-private.
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Sep 14, 2023
Replace `with` calls with in-place mutation; clean up helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chaining the keypath-taking
with(...)methods results in more "functional" looking code, but when there are multiple mutations that need to be made, I've found that it's often cleaner to just create a mutable copy of the node and mutate the properties in-place.Also clean up some various helper extensions that were throughout the code base; some were no longer being used, others no longer held their weight, and some needed to be modernized.