Fix test runner build on WASI #7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test runner build was failing on WASI due to: * Missing `WASILibc` import * The use of `flock` and `open` which are not available on WASI. * Signature incompatibility of `XCTMain` on WASI.
kateinoigakukun
requested review from
bnbarham,
MaxDesiatov,
neonichu and
tomerd
as code owners
|
@swift-ci Please smoke test |
|
@bnbarham actually there are more tests here I forgot about, but surfaced in this PR. |
|
@MaxDesiatov What do you mean "tests" here? The test runner can be built on any developer's machine not limited to our CI |
|
Ah, ok, sorry about the confusion. This is about |
|
Ensuring that the runner can be built for WASI requires actual Swift SDK, so i think we don't have good way to have a regression test in this repository unfortunately 😢 But we can have a validation test on our SwiftWasm build pipeline just in case. |
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@swift-ci test windows |
MaxDesiatov
approved these changes
Feb 16, 2024
kateinoigakukun
added a commit
to kateinoigakukun/swift-package-manager
that referenced
this pull request
Feb 20, 2024
The test runner build was failing on WASI after the introduction of the experimental summary output. This PR fixes several minor issues to pass `--build-tests` build on WASI: * Missing `WASILibc` import * The use of `flock` which is not available on WASI. * Signature incompatibility of `XCTMain` on WASI. `swift build --build-tests --triple wasm32-unknown-wasi` will pass when compiler supports the target.
MaxDesiatov
pushed a commit
that referenced
this pull request
Apr 3, 2024
🍒 #7341 * **Explanation**: `swift build --build-tests` fails on WASI after the experimental summary output, which is introduced in 5.10. This affects not only experimental-summary mode but also the default output mode. * **Scope**: Test build targeting WebAssembly * **Risk**: Low, only affects to WebAssembly targets * **Testing**: Integration test with WebAssembly Swift SDK on CI is infeasible, so I manually tested. We can ensure there is no breakage on other platforms on CI. * **Reviewer**: @MaxDesiatov * **Main branch PR**: #7341
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
### Motivation: The test runner build was failing on WASI after the introduction of the experimental summary output. ### Modifications: This PR fixes several minor issues to pass `--build-tests` build on WASI: * Missing `WASILibc` import * The use of `flock` which is not available on WASI. * Signature incompatibility of `XCTMain` on WASI. ### Result: `swift build --build-tests --triple wasm32-unknown-wasi` will pass when compiler supports the target.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
### Motivation: The test runner build was failing on WASI after the introduction of the experimental summary output. ### Modifications: This PR fixes several minor issues to pass `--build-tests` build on WASI: * Missing `WASILibc` import * The use of `flock` which is not available on WASI. * Signature incompatibility of `XCTMain` on WASI. ### Result: `swift build --build-tests --triple wasm32-unknown-wasi` will pass when compiler supports the target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The test runner build was failing on WASI after the introduction of the experimental summary output.
Modifications:
This PR fixes several minor issues to pass
--build-testsbuild on WASI:WASILibcimportflockwhich is not available on WASI.XCTMainon WASI.Result:
swift build --build-tests --triple wasm32-unknown-wasiwill pass when compiler supports the target