Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Keyword suffix from Pound* #1862

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Jun 28, 2023

Resolves #1834

companion PRs
swiftlang/sourcekit-lsp#764

@kimdv kimdv requested a review from ahoppen as a code owner June 28, 2023 18:29
@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch 2 times, most recently from 6d98e06 to a576655 Compare June 28, 2023 19:37
Copy link
Contributor

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahoppen
Copy link
Contributor

ahoppen commented Jul 6, 2023

@swift-ci Please test

@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch from a576655 to 23842a0 Compare July 7, 2023 15:57
@kimdv
Copy link
Contributor Author

kimdv commented Jul 7, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch from 23842a0 to 44a231a Compare July 7, 2023 20:03
@kimdv
Copy link
Contributor Author

kimdv commented Jul 7, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Jul 8, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test windows

@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch from 44a231a to 7d98ad0 Compare July 8, 2023 14:34
@kimdv
Copy link
Contributor Author

kimdv commented Jul 8, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Jul 8, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test windows

@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch from 7d98ad0 to a9846c5 Compare July 13, 2023 05:34
@kimdv
Copy link
Contributor Author

kimdv commented Jul 13, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch from a9846c5 to adfb613 Compare July 13, 2023 06:04
@kimdv
Copy link
Contributor Author

kimdv commented Jul 13, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch 2 times, most recently from b02d210 to 31ba102 Compare July 13, 2023 19:14
@kimdv
Copy link
Contributor Author

kimdv commented Jul 13, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Jul 13, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test windows

@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch from 31ba102 to 2c67029 Compare July 18, 2023 12:02
@kimdv
Copy link
Contributor Author

kimdv commented Jul 18, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Jul 18, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test windows

1 similar comment
@kimdv
Copy link
Contributor Author

kimdv commented Jul 18, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test windows

@kimdv kimdv force-pushed the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch from 2c67029 to 80a775c Compare July 18, 2023 21:46
@kimdv
Copy link
Contributor Author

kimdv commented Jul 18, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Jul 18, 2023

swiftlang/sourcekit-lsp#764

@swift-ci please test windows

@kimdv kimdv merged commit d5c8158 into swiftlang:main Jul 19, 2023
3 checks passed
@kimdv kimdv deleted the kimdv/1834-drop-keyword-suffix-from-tokenkindpoundavailablekeyword-etc branch July 19, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Keyword suffix from TokenKind.poundAvailableKeyword etc.
2 participants