Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Error out on invalid LLDB build configurations on OS X."
This reverts commit b08610b. The check for LLDB build variant really needs to happen in build-script-impl. build-script can still take options after the '--' separator that may control the final determination of the LLDB build variant. These weren't all being considered by the logic in build-script.
- Loading branch information
02a493b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Is it possible to make the
build-script-impl
-only options go away in all the common cases? I'd rather keep all the logic up inbuild-script
and leavebuild-script-impl
as a low-level thing. (Which we eventually want to redo in Python, so that we're not crossing language boundaries for silly reasons.)02a493b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
02a493b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.