-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebAssembly] Use absolute pointers #31676
Conversation
@compnerd could you have a look at this please? Thanks! |
This seems fine, but doesn’t IRGen need to be updated as well? |
@compnerd it does, would you like me to include that in this PR or a separate PR? |
Yes please, could you make those changes as part of this PR? |
Similar to #31811, it'd be nice if we could make this behavior conditional on the |
cc850ed
to
9b94510
Compare
@swift-ci please smoke test |
@jckarter I'm happy to make this conditional based on the Runtime template argument, but I'm not sure how that argument should be passed. Also, even with that approach the point of use of |
From our forum discussion, we are going to use absolute pointer only for function pointer #42094 |
WebAssembly target uses absolute pointers, as explained by @kateinoigakukun on Swift Forums:
As confirmed by @jckarter:
Related to SR-9307.