Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Runtime] Define WASI MutexPThread macros as 0 #31678

Merged
merged 1 commit into from
May 9, 2020
Merged

[Runtime] Define WASI MutexPThread macros as 0 #31678

merged 1 commit into from
May 9, 2020

Conversation

MaxDesiatov
Copy link
Contributor

WebAssembly/WASI target doesn't compile with MutexPThread constexpr macros defined as 1 due lack of support for threading/locking, previously reported in SR-12097.

Related to SR-9307.

@MaxDesiatov MaxDesiatov changed the title [Runtime] Define WebAssembly/WASI MutexPThread macros as 0 [Runtime] Define WASI MutexPThread macros as 0 May 9, 2020
@MaxDesiatov
Copy link
Contributor Author

@CodaFi would you like a separate SR for this one too?

@MaxDesiatov MaxDesiatov mentioned this pull request May 9, 2020
Closed
78 tasks
@CodaFi
Copy link
Contributor

CodaFi commented May 9, 2020

This one’s fine as-is.

@swift-ci smoke test

@CodaFi CodaFi merged commit 9eb4079 into swiftlang:master May 9, 2020
@MaxDesiatov MaxDesiatov deleted the patch-2 branch May 10, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaxDesiatov @CodaFi @compnerd