test: fix stdlib tests when targeting WebAssembly/WASI #39519
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
MaxDesiatov
changed the title
|
@swift-ci please test Windows platform |
| @@ -335,6 +337,36 @@ public func evaluateObservationsAllEqual<T : Equatable>(_ observations: [T]) | |||
| return .pass | |||
| } | |||
|
|
|||
| // WebAssembly/WASI doesn't support multi-threading yet | |||
There was a problem hiding this comment.
Can we not just mark the test as UNSUPPORTED on OS=wasi instead?
There was a problem hiding this comment.
This isn't a lit test. Can any test in StdlibUnittest be marked as UNSUPPORTED?
There was a problem hiding this comment.
I guess compnerd said we can put unsupported statements for each test case, right?
There was a problem hiding this comment.
Sorry, not sure what you mean here, could you share an example?
|
according to the spec https://webassembly.github.io/spec/core/intro/overview.html:
This means that traps shut down the whole WebAssembly VM, and it's up to the host environment to restart it or not. But I don't think there's anything that the compiler can do to intercept such trap. |
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
|
Tests were fully passing on all platforms. When merging I assumed no further objections to be resolved were present, let me know otherwise. |
This change adds support for WASI in stdlib tests. Some tests that expect a crash to happen had to be disabled, since there's currently no way to observe such crash from a WASI host.
Related to SR-9307.