Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasm] Disable use of returnaddress in exclusivity diagnostics #42097

Conversation

kateinoigakukun
Copy link
Member

Function calls and returns in Wasm are protected by Wasm runtime
and there is no way to get or control return address.

Function calls and returns in Wasm are protected by Wasm runtime
and there is no way to get or control return address.
@kateinoigakukun
Copy link
Member Author

@swift-ci Please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should only impact wasm targets, so should be relatively safe as a change.

@kateinoigakukun
Copy link
Member Author

@compnerd Thank you :)

@kateinoigakukun kateinoigakukun merged commit ecf8a35 into swiftlang:main Apr 2, 2022
@kateinoigakukun kateinoigakukun deleted the katei/workaround-returnaddress-wasm branch April 2, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants