[Gardening/Serialization] Fix comment parameter name typeDecl in plac… #59577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -623,7 +623,7 @@ class ModuleFile | |||
| /// Load the methods within the given class that produce | |||
| /// Objective-C class or instance methods with the given selector. | |||
| /// | |||
| /// \param classDecl The class in which we are searching for @objc methods. | |||
| /// \param typeDecl The class in which we are searching for @objc methods. | |||
| /// The search only considers this class and its extensions; not any | |||
| /// superclasses. | |||
| /// | |||
There was a problem hiding this comment.
Could you as well replace occurrences of "class" (where it refers to a type declaration) with "type" throughout this documentation block to match the new parameter name?
P.S. There may be other loadObjCMethods declarations that need similar corrections if you are interested in auditing them.
There was a problem hiding this comment.
For sure. I'll get on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e of classDecl