Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Sema: Emit diagnostics when walking into collection literals with defaulted types" #65318

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Revert "Sema: Emit diagnostics when walking into collection literals with defaulted types" #65318

merged 1 commit into from
Apr 20, 2023

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Apr 20, 2023 •
edited
Loading

Reverts #60323. I am fully reverting the functional parts because this was clearly shown to be undesirable and I no longer have any confidence in what the purpose of 1d21b4e was.

Resolves #63982, resolves #61850.

@xedin
Copy link
Contributor

xedin commented Apr 20, 2023

Please open a PR for 5.9 branch as well.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler itself diagnostics QoI Bug: Diagnostics Quality of Implementation literals Feature → expressions: Literals such as an integer or string literal unexpected warning Bug: Unexpected warning type checker Area → compiler: Semantic analysis labels Apr 20, 2023
This was referenced Apr 20, 2023
Merged
Merged
@AnthonyLatsis AnthonyLatsis force-pushed the revert-f608802cfe498b8684e4ea63603fe99073102ce6 branch from 89fa669 to f76f6ac Compare April 20, 2023 18:56
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis added the expressions Feature: expressions label Apr 20, 2023
@AnthonyLatsis AnthonyLatsis merged commit d224efc into swiftlang:main Apr 20, 2023
@AnthonyLatsis AnthonyLatsis deleted the revert-f608802cfe498b8684e4ea63603fe99073102ce6 branch April 20, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler itself diagnostics QoI Bug: Diagnostics Quality of Implementation expressions Feature: expressions literals Feature → expressions: Literals such as an integer or string literal type checker Area → compiler: Semantic analysis unexpected warning Bug: Unexpected warning
Projects
None yet
Milestone
No milestone
2 participants
@AnthonyLatsis @xedin