Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mem2reg and temprvalueopt on lexical enums #65345

Merged
merged 3 commits into from
Apr 23, 2023

Conversation

meg-gupta
Copy link
Contributor

Support lifetime completion at boundary for lexical values when forceBoundaryCompletion is specified.

Enable mem2reg and temprvalueopt on lexical enums withforceBoundaryCompletion since we know such values are incomplete on trivial paths only.

@meg-gupta
Copy link
Contributor Author

Please test with following PRs:
#65367

@swift-ci please test

@meg-gupta
Copy link
Contributor Author

Please test with following PR:
#65367

@swift-ci Please test Linux platform

Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/SILOptimizer/Transforms/SILMem2Reg.cpp Outdated Show resolved Hide resolved
@meg-gupta
Copy link
Contributor Author

@swift-ci test and merge

@meg-gupta
Copy link
Contributor Author

@swift-ci test and merge

@swift-ci swift-ci merged commit 12f2c2e into swiftlang:main Apr 23, 2023
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants