Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extraneous ')' #71807

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Fixed extraneous ')' #71807

merged 2 commits into from
Feb 27, 2024

Conversation

dhoepfl
Copy link
Contributor

@dhoepfl dhoepfl commented Feb 22, 2024

Removed extraneous ')'.

Resolves #71806

@dhoepfl dhoepfl closed this Feb 22, 2024
@dhoepfl dhoepfl deleted the patch-1 branch February 22, 2024 10:10
@dhoepfl dhoepfl restored the patch-1 branch February 22, 2024 10:11
@dhoepfl
Copy link
Contributor Author

dhoepfl commented Feb 22, 2024

Sorry, I tried to rename the branch.

@dhoepfl dhoepfl reopened this Feb 22, 2024
@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test

@slavapestov
Copy link
Contributor

@bnbarham It looks like we don't have a CI job that tests with SWIFT_BUILD_SWIFT_SYNTAX off. Should we remove the build setting?

@bnbarham
Copy link
Contributor

@bnbarham It looks like we don't have a CI job that tests with SWIFT_BUILD_SWIFT_SYNTAX off. Should we remove the build setting?

I don't think we should remove it right now, but we are working our way towards it (CC @DougGregor). Might make sense to have a CI job for it specifically, though it's likely we'd still get cases like this as it wouldn't be a PR test.

@DougGregor
Copy link
Member

@swift-ci please smoke test Windows

@DougGregor
Copy link
Member

I don't think it's worth the effort to bring up a CI job where SWIFT_BUILD_SWIFT_SYNTAX is off, since our trajectory is toward requiring swift-syntax in all compiler builds.

@DougGregor DougGregor merged commit ea7a4e4 into swiftlang:main Feb 27, 2024
3 checks passed
@finagolfin
Copy link
Contributor

There is already a CI that builds with it off, the community Android CI, so if you ever want to check its status on linux, that CI's linked from the main README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code fails to compile: extraneous ')' before ';'
6 participants