[6.0] SIL: Consistently drop substitution map when forming apply instructions #74275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 cherry-pick of #74266
Description: Fixes a spurious diagnostic with
@_noLocks. We diagnose partial applies that have non-empty substitution maps in a special SIL pass. As a result of the pack element capture changes, SILGen would sometimes generate a partial apply of a non-generic closure with a non-empty substitution map. This change asserts that the substitution map is non-empty if and only if the callee's generic signature is non-empty, and fixes the fallout from adding this assert.Origination: The specific test case here regressed recently but the invariant in question was never enforced so it was always broken.
Risk: The new assertion might uncover more bugs in assert builds, but otherwise very low.
Radar: rdar://129298104
Reviewed by: @eeckstein