Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more browsers to DestinationEnvironment #228

Merged
merged 3 commits into from May 28, 2021
Merged

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Mar 18, 2021

Ref #227. Not sure if .edge is intended to represent Chrome-Edge or legacy Edge.

@j-f1 j-f1 added the bug Something isn't working label Mar 18, 2021
@MaxDesiatov MaxDesiatov changed the title Add support for Chrome, Edge, and Safari to DestinationEnvironment Add more browsers to DestinationEnvironment Apr 27, 2021
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@MaxDesiatov
Copy link
Collaborator

Thanks! Sorry it took so long to get this merged 😔

@MaxDesiatov MaxDesiatov merged commit 7204aa4 into main May 28, 2021
@MaxDesiatov MaxDesiatov deleted the improve-ua-parsing branch May 28, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants