Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @main attributes #378

Merged

Conversation

noppefoxwolf
Copy link
Contributor

It can be used the @main attribute if the filename is App.swift. like SwiftUI.
Is there a reason that filename is main.swift?

@kateinoigakukun kateinoigakukun added the bug Something isn't working label Sep 14, 2022
@kateinoigakukun
Copy link
Member

Hmm, swiftlint action somehow failed to fetch main branch and shows violation diagnostics for unchanged lines. Please ignore it for now.

Also IntegrationTests.testTokamakBundle is failing. carton init invokes swift package init, then rewrites some sources, and swift package init creates main.swift. So we need to remove it to avoid having both App.swift and main.swift

Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit bdb5d59 into swiftwasm:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants