Build IndexStore together with the host toolchain #1456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
the
continuous integration
MaxDesiatov
changed the title
Previously, the flag was omitted, causing function types which were otherwise the same to have the same id, leading to caching woes. Here, the issue is fixed by adding the boolean flag to the id, ensuring that types which differ only in that flag are still understood to be different.
…tionType-profile
Codesign the Error binary before executing
…ance cache to use it. ConcurrentReadableHashMap is lock-free for readers, with writers using a lock to ensure mutual exclusion amongst each other. The intent is to eventually replace all uses ConcurrentMap with ConcurrentReadableHashMap. ConcurrentReadableHashMap provides for relatively quick lookups by using a hash table. Rearders perform an atomic increment/decrement in order to inform writers that there are active readers. The design attempts to minimize wasted memory by storing the actual elements out-of-line, and having the table store indices into a separate array of elements. The protocol conformance cache now uses ConcurrentReadableHashMap, which provides faster lookups and less memory use than the previous ConcurrentMap implementation. The previous implementation caches ProtocolConformanceDescriptors and extracts the WitnessTable after the cache lookup. The new implementation directly caches the WitnessTable, removing an extra step (potentially a quite slow one) from the fast path. The previous implementation used a generational scheme to detect when negative cache entries became obsolete due to new dynamic libraries being loaded, and update them in place. The new implementation just clears the entire cache when libraries are loaded, greatly simplifying the code and saving the memory needed to track the current generation in each negative cache entry. This means we need to re-cache all requested conformances after loading a dynamic library, but loading libraries at runtime is rare and slow anyway. rdar://problem/67268325
rdar://problem/67155695
…d swiftpm Along with options to disable the mandatory clean using: `--skip-clean-swift-driver` and `--skip-clean-swiftpm`. This will ensure that every invocation of build-script will, by default, clean up all build artifacts of these projects and re-build them from scratch. This is needed for all builds because today arbitrary changes to the compiler can lead to us being unable to incrementally build components that are themselves written in Swift. This causes now-frequent failures in incremental build bots, and is a scenario that is encountered by developers. (For example see: rdar://65006593) The proper long-term solution is to enable library evolution for these projects. Until this is done, the only safe thing to do is to always rebuild them. Resolves rdar://65006593
"do" blocks will always go through buildBlock().
… symbol-visibility-linux.test-sh.
… scan This scanning mode allows swift-driver to query module dependencies in a batch and in a more granular way. In short term, it could help solve a problem that clang module dependencies may vary if target triple changes. In a longer term, we could break a holistic dependencies graph into smaller pieces for better caching and reusing. This change doesn't include the implementation of using the specified scanner arguments to set up Clang dependencies scanner. It will come in later commits.
[PrintAsObjC] Forward-declare bridged types
…itly in batch scan input
[CodeCompletion] Avoid prioritizing unavailable in LookupVisibleDecls
Fixes rdar://67435472.
When @compatibility_alias is used with an ObjC generic class, this ends up importing as a generic typealias. PrintAsObjC previously didn’t handle declarations involving these types correctly; it would fail an assertion in asserts compilers, and potentially print an incorrect compatibility header in non-asserts compilers. This PR makes it so that PrintAsObjC can now correctly use generic typealiases imported from Objective-C modules. It is, of course, still not possible to declare a generic typealias in Swift that will be printed into the Objective-C header. Fixes rdar://67256866.
…ns"" This reverts commit bf25a01.
…ted types Extensions to implementation-only types are accepted at type-checking only if they don't define any public members. However if they declared a conformance to a public type they were also printed in the swiftinterface, making it unparsable because of an unknown type. Still accept such extensions but don't print them. rdar://problem/67516588
[SR-13461] Relax An Assert
…in-sil-setup Setup code for Clang types in SIL.
Add error reporting when looking up types by demangled name.
…ctor expressions that contain code completions.
…ompletion exprs and type check them for code completion. Fixes up some tests marked as non-ideal to give the ideal result now too.
…ayed parsing as well We were previously only doing it when parsing up front.
CSGen: Infer generic arguments for explicit closure result types
…247649fefab99d7dc7b [ownership] Move SemanticARCOpts into a separate folder in preparation for splitting into multiple small pseudo-passes.
…20c96bca2d5cb988ddb
…t-async [Concurrency] Import Objective-C methods with completion handlers as async
…NATIVE_CLANG_TOOLS_PATH (apple#33675)
[Parse][IDE] Various parser fixes for code completion
…merge # Conflicts: # stdlib/public/stubs/ThreadLocalStorage.cpp # utils/build_swift/build_swift/driver_arguments.py
MaxDesiatov
force-pushed
the
maxd/indexstore
branch
from
9425d6a
to
81b0cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexStore is required for
swift build --enable-test-discoveryto work.