[pull] swiftwasm from main #4914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
If `CompletionContextFinder` fails to find a `CompletionNode`, skip trying to filter and add solutions to the completion callback. This prevents an assertion/crash in `filterSolutionsForCodeCompletion` which assumes `CompletionNode` is non-null (either an expression or keypath). Resolves rdar://99966094.
The function that adds runtime link flags overrides RPATH settings via
`BUILD_WITH_INSTALL_RPATH`. Stop doing that for unit tests, because they
depend on host libraries built into `lib` not `lib/swift/${platformname}`.
…ts file This allows us to more gracefully degrade when a host Swift toolchain can't be found, and the early SwiftSyntax build is skipped as a result.
The CxxIntop tests require that CxxShim be created. This module is created with the `libstdcxx-modulemap` target, which is part of the sdk-overlay. If the CxxInterop parts are being tested, then the tests depend on the sdk-overlay.
The constructors-copy-irgen and constructors-irgen tests check code generated by the X86 and ARM backends and will fail spectacularly if we don't have the backend enabled. Adding the necessary codegenerator requirements to those tests.
Fixing Cxx Interop Tests
Such decls don't provide useful coverage info. rdar://83253091
…objc_fixes Updating Swift tests to remove outdated tests and use more current calls
…erface [Sema] Don't error on public imports of private modules in a swiftinterface
…n-skip [Sema] Skip adding solutions to completion callback if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )