Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login password more then 24 characters will be cut .... #10

Closed
joseph991229 opened this issue Sep 18, 2019 · 4 comments
Closed

Login password more then 24 characters will be cut .... #10

joseph991229 opened this issue Sep 18, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@joseph991229
Copy link

Is your feature request related to a problem? Please describe.
In src/renderer/javascripts/components/main/body/aside/form/login.js,
we can see line35, have set the password field maxlength=24,
so if password more then 24, that will be cut...
and fields maxlength is necessary?

@joseph991229 joseph991229 added the enhancement New feature or request label Sep 18, 2019
@alchaplinsky
Copy link
Member

Hey @joseph991229,
well the maxlength itself is necessary for security reasons. However, the number of characters can vary. My initial thought was 24 characters should be enough for passwords. Do you have a case with password longer than that?

@joseph991229
Copy link
Author

Hi @alchaplinsky
In face, i try to save my cloud secret with swifty. The cloud secrets, just like AWS, google and so on are always more then 24 characters So is this a good idea to save secrets more the 24 char in swifty?

thanks your time

@alchaplinsky
Copy link
Member

@joseph991229 Ok I see. That is useful info, I will consider increasing maxlength for password field in next releases. In the meantime, you can use secure notes for storing cloud credentials. Note's body is not limited in length.

@joseph991229
Copy link
Author

@alchaplinsky thanks your info. have a good day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants