Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Add separate .swiftlint file to tests #285

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

swiftyfinch
Copy link
Owner

Description

I've added a separate .swiftlint file to Tests folder to use more lenient rules in tests.

References

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the ⚙️ Engineering Task Technical stuff label Nov 24, 2023
@swiftyfinch swiftyfinch self-assigned this Nov 24, 2023
@swiftyfinch swiftyfinch marked this pull request as ready for review November 24, 2023 18:45
@swiftyfinch swiftyfinch enabled auto-merge (rebase) November 24, 2023 18:45
@swiftyfinch swiftyfinch marked this pull request as draft November 24, 2023 18:46
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecb0302) 33.29% compared to head (e5eb5c3) 33.29%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   33.29%   33.29%           
=======================================
  Files         142      142           
  Lines        4163     4163           
=======================================
  Hits         1386     1386           
  Misses       2777     2777           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch marked this pull request as ready for review November 24, 2023 18:58
@swiftyfinch swiftyfinch enabled auto-merge (rebase) November 24, 2023 18:58
@swiftyfinch swiftyfinch merged commit 8594128 into main Nov 24, 2023
10 checks passed
@swiftyfinch swiftyfinch deleted the swiftlint-in-tests branch November 24, 2023 19:07
@swiftyfinch swiftyfinch added the workflow GitHub Actions, scripts, etc. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Engineering Task Technical stuff workflow GitHub Actions, scripts, etc.
Projects
None yet
1 participant