Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› Fixed relative paths in file hasher when they even outside of $PWD parent #288

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

swiftyfinch
Copy link
Owner

Description

Sometimes modules can be outside of working directory.
We need to find nearest common parent to convert paths to relative ones during hash process.
Read more in the issue reference.

References

Checklist (I have ...)

  • ๐Ÿง Followed the code style of the rest of the project
  • ๐Ÿ“– Updated the documentation, if necessary
  • ๐Ÿ‘จ๐Ÿปโ€๐Ÿ”ง Added at least one test which validates that my change is working, if appropriate
  • ๐Ÿ‘ฎ๐Ÿปโ€โ™‚๏ธ Run make lint and fixed all warnings
  • โœ… Run make test and fixed all tests

โค๏ธ Thanks for contributing to the ๐Ÿˆ Rugby!

@swiftyfinch swiftyfinch added ๐Ÿ› Bug Something isn't working tests Usually automated testing labels Nov 25, 2023
@swiftyfinch swiftyfinch self-assigned this Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests โœ…

Comparison is base (16fe122) 36.53% compared to head (7a15c6e) 36.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   36.53%   36.55%   +0.01%     
==========================================
  Files         142      142              
  Lines        4171     4172       +1     
==========================================
+ Hits         1524     1525       +1     
  Misses       2647     2647              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch marked this pull request as ready for review November 25, 2023 18:38
@swiftyfinch swiftyfinch merged commit d82c909 into main Nov 25, 2023
11 checks passed
@swiftyfinch swiftyfinch deleted the fix-relative-path branch November 25, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ› Bug Something isn't working tests Usually automated testing
Projects
None yet
1 participant