Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸŽ๏ธ Speed up the process of deleting sources #372

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

swiftyfinch
Copy link
Owner

Description

  • I've sped up deleting sources in the multi-proj configuration up to 10x
  • I've fixed the help output width
  • I've implemented an ability to add warmup headers in the cache command

Checklist (I have ...)

  • ๐Ÿง Followed the code style of the rest of the project
  • ๐Ÿ“– Updated the documentation, if necessary
  • ๐Ÿ‘จ๐Ÿปโ€๐Ÿ”ง Added at least one test which validates that my change is working, if appropriate
  • ๐Ÿ‘ฎ๐Ÿปโ€โ™‚๏ธ Run make lint and fixed all warnings
  • โœ… Run make test and fixed all tests

โค๏ธ Thanks for contributing to the ๐Ÿˆ Rugby!

@swiftyfinch swiftyfinch self-assigned this Mar 16, 2024
@swiftyfinch swiftyfinch changed the title Delete sources speedup ๐ŸŽ๏ธ Speed up sources deleting Mar 16, 2024
@swiftyfinch swiftyfinch changed the title ๐ŸŽ๏ธ Speed up sources deleting ๐ŸŽ๏ธ Speed up the process of deleting sources Mar 16, 2024
@swiftyfinch swiftyfinch enabled auto-merge (rebase) March 16, 2024 16:47
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.32%. Comparing base (130401d) to head (3b3ec0e).

Files Patch % Lines
...ion/XcodeProject/Services/XcodeTargetsEditor.swift 0.00% 3 Missing โš ๏ธ
Sources/Rugby/Core/Help/HelpPrinter.swift 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   64.34%   64.32%   -0.02%     
==========================================
  Files         146      146              
  Lines        3733     3734       +1     
==========================================
  Hits         2402     2402              
- Misses       1331     1332       +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit d0c23e2 into main Mar 16, 2024
9 of 11 checks passed
@swiftyfinch swiftyfinch deleted the delete-sources-speedup branch March 16, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant