Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Lint by new rule non_optional_string_data_conversion #399

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

swiftyfinch
Copy link
Owner

References

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the ⚙️ Engineering Task Technical stuff label May 29, 2024
@swiftyfinch swiftyfinch self-assigned this May 29, 2024
@swiftyfinch swiftyfinch changed the title ⚙️ Lint new rule non_optional_string_data_conversion ⚙️ Lint by new rule non_optional_string_data_conversion May 29, 2024
@swiftyfinch swiftyfinch enabled auto-merge (squash) May 29, 2024 16:30
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.13%. Comparing base (0ac1175) to head (fcb1b84).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   64.13%   64.13%           
=======================================
  Files         153      153           
  Lines        3956     3956           
=======================================
  Hits         2537     2537           
  Misses       1419     1419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit b53c636 into main May 29, 2024
11 checks passed
@swiftyfinch swiftyfinch deleted the lint branch May 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant