octave 4.0 hdf5 support

[opoplawski]

WIth octave 4.0.0 with hdf5 support I get:

/builddir/build/BUILD/plplot-5.11.0/fedora/bindings/octave/plplot_octaveOCTAVE_wrap.cxx:1638:18: error: 'hid_t' has not been declared
       save_hdf5 (hid_t loc_id, const char *name, bool save_as_floats) {
                  ^

swig source is:

#if defined (HAVE_HDF5)
    virtual bool
      save_hdf5 (hid_t loc_id, const char *name, bool save_as_floats) {
      return true;
    }

This now appears to be caused by the update to octave 4.0.0. With 3.8.2:

/usr/include/octave-3.8.2/octave/ov.h:#include "oct-hdf5.h"
/usr/include/octave-3.8.2/octave/oct-hdf5.h:#include <hdf5.h>

so ov.h included <hdf5.h>. But now:

/usr/include/octave-4.0.0/octave/oct-hdf5.h:#include <hdf5.h>
/usr/include/octave-4.0.0/octave/ls-hdf5.h:#include "oct-hdf5.h"

only ls-hdf5.h or oct-hdf5.h will bring in <hdf5.h>.

Also, octave's definition of save_hdf5 has changed from:

bool save_hdf5 (hid_t loc_id, const char *name, bool save_as_floats)

to

bool save_hdf5 (octave_hdf5_id loc_id, const char *name, bool save_as_floats);

So it looks like Lib/octave/octrun.swg needs to get updated to handle that?

[ojwb]

Looks like this was fixed by PR #460, so closing. If not, please reopen.