-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swig 3.0.8 breaks SVN Ruby bindings #602
Comments
Any chance you can provide a cut down test or is it a no brainer to build svn? |
I am looking at this now and am building svn-1.9.3 now. I see:
Is there something more fundamentally wrong with using swig-3.0.0+ for svn wrappers? |
I'm a bit frustrated that I can't get the test suite to run. Calls to |
The subversion-1.9.3 Ruby test-suite works out the box on Ubuntu-14.04 and recreates this reported bug with ruby-1.9.3p484. The problem is peculiar to Subversion's pattern of using manually written proxy classes to wrap an opaque pointer and deleting them using 'DATA_PTR(self) = 0' in the manually written svn_fs_close function:
146252f is indeed where the regression was introduced and this needs tweaking slightly to revert to the old behaviour and not throw SWIG_ObjectPreviouslyDeletedError. It isn't clear to me which approach is better in this corner case, so I've gone with the old behaviour for backwards compatibility. The subversion ruby tests now pass with the change I've committed. |
Thx for the fix. It appears it fixes the issues with Subversion: |
It seems that Swigh 3.0.8 breaks SVN Ruby bindings. I have tried to compile Subversion against Ruby 2.2.4 and 2.3.0 and in both case, the Subversions test suite breaks:
Build against Swig 3.0.7 works just fine. So I tried revert to Lib/ruby/rubyrun.swg to this version [1] and it worked just fine again. I suspect that 146252f is the cause of the issues.
Just FTR, the particular bits of the test suite can be executed as follows:
[1] https://github.com/swig/swig/blob/3d1e20248f8422681382be8a91c91d456d4595e7/Lib/ruby/rubyrun.swg
The text was updated successfully, but these errors were encountered: