Update for angular 11 #1555
Merged
Update for angular 11 #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timeline.component.ts, timeline-filter-bar-chart.component.ts: delete d3event for brushX (and replace by d3selection in argument)
tooltip.directive.ts: fix bug 'Expecting instance of DOM Element' (in addHideListeners, use 'window' for documentClickEvent)
marjan-georgiev
approved these changes
Jan 3, 2021
|
Thanks! |
|
any ETA on when this will be released? |
hilel
pushed a commit
to hilel/ngx-charts
that referenced
this pull request
Dec 23, 2021
* Update package.json and tsconfig files * update package for d3 timeline.component.ts, timeline-filter-bar-chart.component.ts: delete d3event for brushX (and replace by d3selection in argument) * update package for d3-time-format tooltip.directive.ts: fix bug 'Expecting instance of DOM Element' (in addHideListeners, use 'window' for documentClickEvent) * update package for jasmine and zone.js * run prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Update project and library to Angular 11
What is the current behavior? (You can also link to an open issue here)
#1540
What is the new behavior?
No errors since the library is now build with Angular 11
Does this PR introduce a breaking change? (check one with "x")
Other information: