Support reference line on vertical/horizontal bar chart and area chart #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Lyq322
reviewed
Jan 10, 2024
projects/swimlane/ngx-charts/src/lib/area-chart/area-chart.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/bar-chart/bar-horizontal.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/bar-chart/bar-vertical.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/bar-chart/bar-vertical.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/common/axes/x-axis-ticks.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/common/axes/x-axis-ticks.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior?
Reference lines and reference line labels are not supported on vertical bar chart, horizontal bar chart, and area chart.
Link to Open Issue:
Resolves Issue #1046
What is the new behavior?
This pull request introduces support for maximum, average, and minimum reference lines on vertical bar charts, horizontal bar charts, and area charts. The reference lines will be positioned above the chart to ensure their visibility. This enhancement aims to provide better analytical capabilities and improve the interpretation of the charts.
Does this PR introduce a breaking change? (check one with "x")