Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't resolve all parameters for ScrollbarHelper errror in ngx-datatable with Angular v8.0.0-rc.0 and above #1693

Closed
neetu-pandey opened this issue May 22, 2019 · 20 comments · Fixed by #1697

Comments

@neetu-pandey
Copy link

neetu-pandey commented May 22, 2019

I'm submitting a ... (check one with "x")

[ x] bug report => search github for a similar issue or PR before submitting
[ ] feature request[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
Cannot launch ngx-datatable v14.0.0 with Angular v8.0.0-rc4.
Get the following error:

ERROR Error: Uncaught (in promise): Error: Can't resolve all parameters for ScrollbarHelper: (?).
Error: Can't resolve all parameters for ScrollbarHelper: (?).

Expected behavior
ngx-datatable should render without the error

Reproduction of the problem
https://stackblitz.com/edit/angular8-ngx-datatable

What is the motivation / use case for changing the behavior?
ScrollbarHelper class imports DOCUMENT from @angular/platform-browser. This deprecated import has been removed from Angular in v8.0.0-rc.0.
DOCUMENT should rather be imported from @angular/core.
angular/angular#28117

Please tell us about your environment:
Windows 10, VSC, npm

  • Table version:
    14.0.0

  • Angular version:
    ~8.0.0-rc4 (reproducible since ~8.0.0-rc.0)

  • Browser:
    All

  • Language: All

@neetu-pandey neetu-pandey changed the title Can't resolve all parameters for ScrollbarHelper errror in ngx-datatable Can't resolve all parameters for ScrollbarHelper errror in ngx-datatable with Angular v8.0.0-rc.0 and above May 22, 2019
@bleuscyther
Copy link

i think its in @angular/common

@bleuscyther
Copy link

There is a pull request on angular 8:
#1690

npm rm @swimlane/ngx-datatable
npm install git+https://github.com/zackarychapple/ngx-datatable.git

It seems to work fine for now with ng serve

@pedromarce
Copy link

is there an estimated date when the pull request might be merged?

@yuveliremil
Copy link

When the pull request would be merged?

@marjan-georgiev
Copy link
Member

Released 15.0.0. Please verify.

@neetu-pandey
Copy link
Author

This issue is fixed. Thanks.

@sridharsivichandran
Copy link

sridharsivichandran commented Oct 12, 2019

umable to access this URL : https://github.com/zackarychapple/ngx-datatable.git

@daniloff200
Copy link

LOL
@zackarychapple, I also can't do it :D :D

@daniloff200
Copy link

@sridharsivichandran you can use latest version of ngx-datable, like 16.0.2
if you face some issue with icons path, check the #1741

@zackarychapple
Copy link

Sorry for removing that repo, did not know folks were relying on it. Thank you @daniloff200 for clarifying that the fix has been merged.

@jacques-hoventer
Copy link

jacques-hoventer commented Feb 24, 2020

I still get this error even after uninstalling v 14.x and installing 16.x. I have no idea how to troubleshoot any further than I have.

PS. The ngx-datatable is used in a lazy loaded module, not sure if this makes any difference.

I'm on Angular 8.2.13.

@pradosh123
Copy link

pradosh123 commented May 9, 2020

@jacques-hoventer iam having same issue..you got any solution?

@pradosh123
Copy link

I still get this error even after uninstalling v 14.x and installing 16.x. I have no idea how to troubleshoot any further than I have.

PS. The ngx-datatable is used in a lazy loaded module, not sure if this makes any difference.

I'm on Angular 8.2.13.

iam having same issue..you got any solution?

@jacques-hoventer
Copy link

I can't actually remember how I resolved this. I've since moved on to a different project, but if it comes back to me, I'll come back to you. Apologies.

@Ahmed-Diab
Copy link

i have the same issue any one got solution ?

@daniel-van-niekerk
Copy link

Same issue. Angular 11.0 and ngx-datatable 19.0.0.

The table works in a normal component but not in a mat dialog.

@notenote087
Copy link

Same issue. Angular 11.0 and ngx-datatable 19.0.0.

The table works in a normal component but not in a mat dialog.

Same issue :(

@Predhin
Copy link

Predhin commented May 28, 2021

Same issue!

@Cafnio
Copy link

Cafnio commented Oct 15, 2021

Same issue with modals

@fincha
Copy link

fincha commented Mar 18, 2022

No solution for datatable in modals yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.