Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malware Technique relationship is linked to Actors #37

Closed
BigLeagueChew opened this issue May 19, 2020 · 2 comments
Closed

Malware Technique relationship is linked to Actors #37

BigLeagueChew opened this issue May 19, 2020 · 2 comments

Comments

@BigLeagueChew
Copy link

BigLeagueChew commented May 19, 2020

Hello,

I believe the techniques() method on a AttckMalware class is incorrectly linked to Actor information instead of a Technique. I believe line 112 on malware.py needs to be changed to 'attack-pattern'.
See example below which prints Actor names instead of Technique names.

from pyattck import Attck
attack = Attck()

for mal in attack.enterprise.malwares:
    for technique in mal.techniques:
        print(technique.name)
@joshswimlane
Copy link
Contributor

Thanks! You are correct and I will get this updated today (as well as review the other relationships). Much appreciated!

@BigLeagueChew
Copy link
Author

Thanks Josh.

I might have come across another relationship issue. I'm seeing PreAttckActor class returning what looks like Mitre software "S000" for the IDs. Thoughts?

from pyattck import Attck
attack = Attck()

for actor in attack.preattack.actors:
    print(actor.id, actor.name)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants