fixed inflating uncompressed messages in deflate extension

[GenrikhFetischev]

This PR created as a quick fix of the decompression issue

[GenrikhFetischev]

That was made to satisfy linter, according to rules here - https://github.com/swimos/ratchet/blob/main/ratchet_core/src/lib.rs#L25

[SirCipher]

@GenrikhFetischev, apologies for the very late response and thank you for raising an issue and submitting a fix. While it appears that the logic in the block where you applied your fix is incorrect, your fix does not include support for fragmented messages. For a fragmented message, only the first frame will have rsv1 set high and the subsequent frames will be low. See 7.2.3.1:

Note that the RSV1 bit is set only on the first frame.

For this to work, the decode implementation needs to check if the rsv1 flag has been set high and if the fin flag is low:

        match header.opcode {
            OpCode::Binary | OpCode::Text if header.rsv1 => {
                if !header.fin {
                    *compressed = true;
                    return Ok(());
                }
            }
            OpCode::Continuation if header.fin && *compressed => {}
            _ => return Ok(()),
        }

[GenrikhFetischev]

@SirCipher Yep, good catch!
Would you like me to update PR or your intent is to fix by yourself?
I could do it if you have time to review in the nearest future :)

[SirCipher]

@GenrikhFetischev, you're welcome to submit a PR for it! 😄

[GenrikhFetischev]

@SirCipher ok, will work on it soon 🤝

[GenrikhFetischev]

@SirCipher I have updated PR, could you take a look please?

[SirCipher]

@GenrikhFetischev merged. Thanks for your contributions!

[SirCipher]

@GenrikhFetischev released in https://github.com/swimos/ratchet/releases/tag/v0.4.2

[GenrikhFetischev]

@GenrikhFetischev merged. Thanks for your contributions!

@SirCipher it was a pleasure considering you have provided solution 🙂