Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend / WARP Client documentation #160

Merged
merged 21 commits into from
Mar 14, 2024
Merged

Frontend / WARP Client documentation #160

merged 21 commits into from
Mar 14, 2024

Conversation

cwjames19
Copy link
Contributor

Closes #159

@cwjames19 cwjames19 self-assigned this Feb 27, 2024
afolson
afolson reviewed Feb 27, 2024
View reviewed changes
src/_frontend/downlinks.md Outdated Show resolved Hide resolved
SirCipher
SirCipher requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@SirCipher SirCipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @cwjames19. Just a few nits here and there

src/_frontend/downlinks.md Outdated Show resolved Hide resolved
src/_frontend/downlinks.md Show resolved Hide resolved
src/_frontend/downlinks.md Outdated Show resolved Hide resolved
src/_frontend/downlinks.md Outdated Show resolved Hide resolved
src/_frontend/downlinks.md Outdated Show resolved Hide resolved
src/_frontend/structures.md Outdated Show resolved Hide resolved
src/_frontend/structures.md Outdated Show resolved Hide resolved
src/_frontend/structures.md Outdated Show resolved Hide resolved
src/_frontend/valueDownlink.md Outdated Show resolved Hide resolved
src/_frontend/whatIsWarp.md Outdated Show resolved Hide resolved
cwjames19 and others added 9 commits March 4, 2024 13:27
@cwjames19 @SirCipher
Update src/_frontend/downlinks.md
3a1bbfa 
Co-authored-by: Thomas Klapwijk <SirCipher@users.noreply.github.com>
@cwjames19 @SirCipher
Update src/_frontend/form.md
4d2fb87 
Co-authored-by: Thomas Klapwijk <SirCipher@users.noreply.github.com>
@cwjames19 @SirCipher
Update src/_frontend/structures.md
05d3d8b 
Co-authored-by: Thomas Klapwijk <SirCipher@users.noreply.github.com>
@cwjames19 @SirCipher
Update src/_frontend/valueDownlink.md
8e10208 
Co-authored-by: Thomas Klapwijk <SirCipher@users.noreply.github.com>
@cwjames19 @SirCipher
Update src/_frontend/whatIsWarp.md
08fe0b7 
Co-authored-by: Thomas Klapwijk <SirCipher@users.noreply.github.com>
@cwjames19
Merge branch 'main' into issue-159
1e3a2bb
Improve docs on WarpClient downlink callback methods
e2117bf
Minor doc improvements
96f3813
Merge branch 'issue-159' of https://github.com/swimos/swimos-docs int…
1b31bc7 
…o issue-159
ajay-gov
ajay-gov requested changes Mar 9, 2024
View reviewed changes
Copy link
Member

@ajay-gov ajay-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Just a few changes and mostly suggestions otherwise

src/_frontend/gettingStarted.md Outdated Show resolved Hide resolved
src/_frontend/gettingStarted.md Outdated Show resolved Hide resolved
src/_frontend/warpClient.md Outdated Show resolved Hide resolved
src/_frontend/mapDownlink.md Outdated Show resolved Hide resolved
src/_frontend/valueDownlink.md Outdated Show resolved Hide resolved
src/_frontend/mapDownlink.md Outdated Show resolved Hide resolved
src/_frontend/listDownlink.md Outdated Show resolved Hide resolved
src/_frontend/eventDownlink.md Outdated Show resolved Hide resolved
src/_frontend/structures.md Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

✅ Deploy Preview for scintillating-strudel-60ff56 ready!

Name Link
🔨 Latest commit 45906c7
🔍 Latest deploy log https://app.netlify.com/sites/scintillating-strudel-60ff56/deploys/65f23b54dbdf96000822329c
😎 Deploy Preview https://deploy-preview-160--scintillating-strudel-60ff56.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ajay-gov
ajay-gov approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@ajay-gov ajay-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, looks great.

@ajay-gov ajay-gov merged commit 65d3c13 into main Mar 14, 2024
5 checks passed
@ajay-gov ajay-gov deleted the issue-159 branch March 14, 2024 00:17
@cwjames19 cwjames19 mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afolson afolson afolson left review comments

@ajay-gov ajay-gov ajay-gov approved these changes

@SirCipher SirCipher SirCipher approved these changes

Assignees

@cwjames19 cwjames19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create section for frontend docs
4 participants
@cwjames19 @afolson @ajay-gov @SirCipher