Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The original year of release #204

Open
VlaK0r opened this issue Apr 1, 2024 · 3 comments
Open

The original year of release #204

VlaK0r opened this issue Apr 1, 2024 · 3 comments

Comments

@VlaK0r
Copy link

VlaK0r commented Apr 1, 2024

Hello!
Thank you for your hard work!

There are two types of dates in Musicbrains tags. The first is "date" and the second is "originaldate".
"originaldate" is the release date of the album.
"date" is the release date of the disc.
Swingmusic uses the tag "date".
As a result, it turns out like this.

image

Q: Do you have plans to support Musicbraints tags? Or the ability to select or customize tags?

@cwilvx
Copy link
Member

cwilvx commented Apr 2, 2024

Hello @VlaK0r

Thanks for opening this issue. Swing Music uses the date field which is provided by the TinyTag module used to extract metadata. I don't know whether it supports Musicbrainz tags.

Would you mind sharing a single file that has the musicbrainz tags. I can look at it and see whether I can make it work.

Thanks.

@VlaK0r
Copy link
Author

VlaK0r commented Apr 2, 2024

1.01. Good Times Bad Times - 1969 (2012-11-28) Led Zeppelin - Led Zeppelin.zip

@cwilvx
Copy link
Member

cwilvx commented Apr 2, 2024

@VlaK0r

This is all the metadata extracted from the sample file using Tinytag:

{
    "filename": ".../1.01. Good Times Bad Times - 1969 (2012-11-28) Led Zeppelin - Led Zeppelin.flac",
    "filesize": 19494758,
    "album": "Led Zeppelin",
    "albumartist": "Led Zeppelin",
    "artist": "Led Zeppelin",
    "audio_offset": null,
    "bitrate": 933.5079648842777,
    "channels": 2,
    "comment": null,
    "composer": null,
    "disc": "1",
    "disc_total": "1",
    "duration": 167.06666666666666,
    "extra": {},
    "genre": "Hard Rock",
    "samplerate": 44100,
    "bitdepth": 16,
    "title": "Good Times Bad Times",
    "track": "1",
    "track_total": "9",
    "year": "2012-11-28"
}

There are no music brainz metadata in there. This seems to be an issue with TinyTag. You should open this issue on their repo. Once we have the Music brainz tags in the result (most likely in the extra field), we can make it work from Swing Music.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants