Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update part 3 #81

Merged
merged 75 commits into from
Aug 9, 2023
Merged

Update part 3 #81

merged 75 commits into from
Aug 9, 2023

Conversation

ludelafo
Copy link
Contributor

@ludelafo ludelafo commented Jul 12, 2023

  • Restructure <chapter_name>/index.md to <chapter_name>.md
  • Update "State of MLOps process" with new checkpoint from part 2
  • Update cml report with image branch name title (see Add labels to differentiate main and workspace output #111)
  • Add activate venv warning (see Add venv activation warning #116)
  • Update command outputs from checkpoint generator
  • Update cleanup section with GCP Artifact Registry
  • Update actions.yaml for the checkpoint generator with commands of chapters 11-15

@ludelafo ludelafo linked an issue Jul 12, 2023 that may be closed by this pull request
@rmarquis rmarquis force-pushed the 74-update-part-3 branch 3 times, most recently from dc369ae to 4a58eca Compare July 26, 2023 07:50
@leonardcser leonardcser marked this pull request as draft July 27, 2023 13:29
@leonardcser leonardcser force-pushed the 74-update-part-3 branch 2 times, most recently from 86254c1 to d8d726b Compare July 27, 2023 14:20
@rmarquis rmarquis force-pushed the 74-update-part-3 branch 4 times, most recently from 8eff21a to e0909d4 Compare August 2, 2023 11:50
@ludelafo ludelafo marked this pull request as ready for review August 7, 2023 14:38
@ludelafo
Copy link
Contributor Author

ludelafo commented Aug 9, 2023

The pipeline is failing at the moment because I need to update my credit cards information on Google Cloud.

We might need to find a more sustainable way to host the demo on GCP with a Billing account for the team?

What do you think?

@rmarquis
Copy link
Contributor

rmarquis commented Aug 9, 2023

Definitely a good idea. The current setup of using a personal account is very annoying. Who should we contact to get this rolling? I'm only afraid of the bureaucratic mess to get a team billing account, but the earlier we sort it out the better,

Copy link
Contributor

@rmarquis rmarquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done several passes on this branches the past few weeks (the latest time yesterday). There's still a few todo here and there in the latter chapters to sort out, but we can fix this gradually. Good to merge as of now.

@ludelafo
Copy link
Contributor Author

ludelafo commented Aug 9, 2023

Definitely a good idea. The current setup of using a personal account is very annoying. Who should we contact to get this rolling? I'm only afraid of the bureaucratic mess to get a team billing account, but the earlier we sort it out the better,

I guess we should discuss this with @bchapuis.

@ludelafo ludelafo merged commit daacf0e into main Aug 9, 2023
3 of 4 checks passed
@ludelafo ludelafo deleted the 74-update-part-3 branch August 9, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update part 3
3 participants